smengcl commented on code in PR #9406:
URL: https://github.com/apache/ozone/pull/9406#discussion_r2616012262


##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -2041,6 +2055,15 @@
       file. Unit could be defined with postfix (ns,ms,s,m,h,d)
     </description>
   </property>
+  <property>
+    <name>ozone.om.snapshot.directory.metrics.update.interval</name>
+    <value>5m</value>

Review Comment:
   When I saw this config initially I thought the new metrics are persisted to 
disk somewhere, but that doesn't look to be the case.
   
   If those metrics are in-memory only, the best solution would be to update it 
whenever the event happens so it is (almost) real-time. Although I can 
understand it might be not that easy to implement. We can leave that for future 
improvements.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to