bshashikant commented on a change in pull request #2249:
URL: https://github.com/apache/ozone/pull/2249#discussion_r633485056
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -946,19 +946,32 @@ public static boolean scmInit(OzoneConfiguration conf,
scmStorageConfig.setClusterId(clusterId);
}
- if (SCMHAUtils.isSCMHAEnabled(conf)) {
- SCMRatisServerImpl.initialize(scmStorageConfig.getClusterID(),
- scmStorageConfig.getScmId(), haDetails.getLocalNodeDetails(),
- conf);
- scmStorageConfig.setSCMHAFlag(true);
- }
if (OzoneSecurityUtil.isSecurityEnabled(conf)) {
HASecurityUtils.initializeSecurity(scmStorageConfig, conf,
getScmAddress(haDetails, conf), true);
}
+
+ // Do not move these code lines. If SCM version file is created,
+ // the subsequent scm init should use the groupID from version file.
Review comment:
groupId-> clusterId
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -946,19 +946,32 @@ public static boolean scmInit(OzoneConfiguration conf,
scmStorageConfig.setClusterId(clusterId);
}
- if (SCMHAUtils.isSCMHAEnabled(conf)) {
- SCMRatisServerImpl.initialize(scmStorageConfig.getClusterID(),
- scmStorageConfig.getScmId(), haDetails.getLocalNodeDetails(),
- conf);
- scmStorageConfig.setSCMHAFlag(true);
- }
if (OzoneSecurityUtil.isSecurityEnabled(conf)) {
HASecurityUtils.initializeSecurity(scmStorageConfig, conf,
getScmAddress(haDetails, conf), true);
}
+
+ // Do not move these code lines. If SCM version file is created,
+ // the subsequent scm init should use the groupID from version file.
+ // So, scmStorageConfig#initialize() should happen before ratis server
+ // initialize. In this way,we do not leave ratis storage directory
+ // with multiple raft Groups in failure scenario.
+
Review comment:
multiple raft Groups -> multiple raft group directories
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -946,19 +946,32 @@ public static boolean scmInit(OzoneConfiguration conf,
scmStorageConfig.setClusterId(clusterId);
}
- if (SCMHAUtils.isSCMHAEnabled(conf)) {
- SCMRatisServerImpl.initialize(scmStorageConfig.getClusterID(),
- scmStorageConfig.getScmId(), haDetails.getLocalNodeDetails(),
- conf);
- scmStorageConfig.setSCMHAFlag(true);
- }
if (OzoneSecurityUtil.isSecurityEnabled(conf)) {
HASecurityUtils.initializeSecurity(scmStorageConfig, conf,
getScmAddress(haDetails, conf), true);
}
+
+ // Do not move these code lines. If SCM version file is created,
+ // the subsequent scm init should use the groupID from version file.
Review comment:
Do not move these code lines -> ensure scmRatisserver#initialize() is
called post scm storage config initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
