jojochuang commented on code in PR #9495:
URL: https://github.com/apache/ozone/pull/9495#discussion_r2621112255


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -376,6 +376,11 @@ public void start(OzoneConfiguration configuration) {
    */
   public void startSnapshotSstFilteringService(OzoneConfiguration conf) {
     if (isSstFilteringSvcEnabled()) {
+      if (isDefragSvcEnabled()) {
+        LOG.info("SstFilteringService is disabled (despite config intends to 
enable it) " +
+            "because SnapshotDefragService is enabled. Defrag effectively 
performs filtering already.");

Review Comment:
   maybe add another line when isSstFilteringSvcEnabled(), log 
"SstFilteringService to be removed in a future release" (if my memory serves me 
right, we discussed about it before)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to