swamirishi commented on code in PR #9500:
URL: https://github.com/apache/ozone/pull/9500#discussion_r2622226670
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/FSORepairTool.java:
##########
@@ -553,7 +553,7 @@ private Collection<String>
getChildDirectoriesAndMarkAsPendingToDelete(String di
private void addReachableEntry(OmVolumeArgs volume, OmBucketInfo bucket,
WithObjectID object) throws IOException {
String reachableKey = buildReachableKey(volume, bucket, object);
// No value is needed for this table.
- reachableTable.put(reachableKey, EMPTY_BYTE_ARRAY);
+ reachableTable.put(reachableKey, CodecBuffer.getEmptyBuffer());
Review Comment:
Same comment as below
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/FSORepairTool.java:
##########
@@ -562,7 +562,7 @@ private void addReachableEntry(OmVolumeArgs volume,
OmBucketInfo bucket, WithObj
*/
private void addPendingToDeleteEntry(String originalKey) throws
IOException {
// No value is needed for this table.
- pendingToDeleteTable.put(originalKey, EMPTY_BYTE_ARRAY);
+ pendingToDeleteTable.put(originalKey, CodecBuffer.getEmptyBuffer());
Review Comment:
Not related to this PR but would it be better to use RocksDB batch here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
