ivandika3 commented on code in PR #9513:
URL: https://github.com/apache/ozone/pull/9513#discussion_r2625454981
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -807,6 +807,8 @@ public Response putBucketLifecycleConfiguration(
OmLifecycleConfiguration lcc =
s3LifecycleConfiguration.toOmLifecycleConfiguration(ozoneBucket);
ozoneBucket.setLifecycleConfiguration(lcc);
+ } catch (OS3Exception ex) {
+ throw ex;
Review Comment:
This seems unnecessary. We can simply let `OS3Exception` to be thrown all
the way and handled in `OS3ExceptionMapper`.
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/S3LifecycleConfiguration.java:
##########
@@ -265,6 +265,8 @@ public OmLifecycleConfiguration
toOmLifecycleConfiguration(OzoneBucket ozoneBuck
}
return builder.buildAndValid();
+ } catch (OS3Exception ex) {
+ throw ex;
Review Comment:
This also seems unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
