priyeshkaratha commented on code in PR #9488:
URL: https://github.com/apache/ozone/pull/9488#discussion_r2625955115
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/StorageDistributionEndpoint.java:
##########
@@ -221,6 +221,7 @@ private long calculateCommittedSize() {
private DatanodeStorageReport getStorageReport(DatanodeDetails datanode) {
try {
SCMNodeMetric nodeMetric = nodeManager.getNodeStat(datanode);
+ long reservedSpace = nodeManager.getTotalReserved(datanode);
Review Comment:
Currently, `SCMNodeMetric` does not have this information. Since the
command-line tool already relies on `NodeManager`, I thought it would be better
to reuse the same approach.
Adding this to `SCMNodeMetric` would require redefining multiple classes,
and since SCM does not use this value for any other purpose, do we really need
to introduce it into `SCMNodeMetric`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
