echonesis commented on code in PR #9457:
URL: https://github.com/apache/ozone/pull/9457#discussion_r2626219460
##########
hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v1/AbstractS3SDKV1Tests.java:
##########
@@ -143,7 +146,7 @@
*
*/
@TestMethodOrder(MethodOrderer.MethodName.class)
-public abstract class AbstractS3SDKV1Tests extends OzoneTestBase {
Review Comment:
Removal of `OzoneTestBase` should be consistent between `V1` and `V2`.
The `V2` version still extends `OzoneTestBase`, so `getTestName()` returns a
fixed test method name instead of a random string. This could cause naming
conflicts in parallel test execution.
Consider removing `OzoneTestBase` from V2 as well and adding the same
random-based `getTestName()` method.
##########
hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v1/AbstractS3SDKV1Tests.java:
##########
@@ -1384,6 +1387,86 @@ public void testPresignedUrlDelete() throws IOException {
}
}
+ @Nested
+ @TestInstance(TestInstance.Lifecycle.PER_CLASS)
+ class BucketOwnershipLinkBucketTests {
Review Comment:
Maybe we could keep it consistent with [the V2
class](https://github.com/apache/ozone/blob/2029b59898a737a9c5d4a1ee54195fa16e7ed369/hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v2/AbstractS3SDKV2Tests.java#L1673)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
