SaketaChalamchala commented on code in PR #9489:
URL: https://github.com/apache/ozone/pull/9489#discussion_r2629117955
##########
hadoop-hdds/rocks-native/src/main/java/org/apache/hadoop/hdds/utils/db/ManagedRawSSTFileReader.java:
##########
@@ -62,14 +64,14 @@ public ManagedRawSSTFileReader(final ManagedOptions
options, final String fileNa
this.nativeHandle = this.newRawSSTFileReader(options.getNativeHandle(),
fileName, readAheadSize);
}
- public ManagedRawSSTFileIterator<T> newIterator(
+ public <T> ManagedRawSSTFileIterator<T> newIterator(
Function<ManagedRawSSTFileIterator.KeyValue, T> transformerFunction,
ManagedSlice fromSlice, ManagedSlice toSlice, IteratorType type) {
long fromNativeHandle = fromSlice == null ? 0 :
fromSlice.getNativeHandle();
long toNativeHandle = toSlice == null ? 0 : toSlice.getNativeHandle();
LOG.info("Iterating SST file: {} with native lib. " +
"LowerBound: {}, UpperBound: {}, type : {}", fileName, fromSlice,
toSlice, type);
- return new ManagedRawSSTFileIterator<>(
+ return new ManagedRawSSTFileIterator<>(fileName,
Review Comment:
nit: Would it help to append `fileName` with a unique suffix for better
debuggability in rare cases where multiple SSTFileReaders are reading key/value
from the same SST file at the same time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
