[
https://issues.apache.org/jira/browse/HDDS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Andika updated HDDS-14201:
-------------------------------
Description:
We have contract tests in AbstractOzoneContractTest, which implements
createConfiguration and createContract.
There are a few issues with the configurations, not sure if there are any
reasons
* createConfiguration does not call the super.createConfiguration
** For example, AbstractContractSeekTest#createConfiguration set
"io.file.buffer.size" configuration, but since
TestContractSeek#createConfiguration does not call
AbstractContractSeekTest#createConfiguration and simply calls
AbstractOzoneContractTest#createOzoneConfig
** This means that "io.file.buffer.size" remains unchanged
* AbstractOzoneContractTest#createOzoneContract implementations ignore the
passed Configuration
** See createContract in AbstractFSContractBase#setup
** See TestRootedOzoneContract, TestOzoneContractFSO, TestOzoneContractLegacy
** Instead, the MiniOzoneCluster#getConf is the one used, so the configuration
created in createConfiguration is discarded
This causes issues when the contract test wants to use the configuration (e.g.
by calling getContract().getConf()) and the configuration fields are not set.
was:
We have contract tests in AbstractOzoneContractTest, which implements
createConfiguration and createContract.
There are a few issues with the configurations, not sure if there are any
reasons
* createConfiguration does not call the super.createConfiguration
** For example, AbstractContractSeekTest#createConfiguration set
"io.file.buffer.size" configuration, but since
TestContractSeek#createConfiguration does not call
AbstractContractSeekTest#createConfiguration and simply calls
AbstractOzoneContractTest#createOzoneConfig
** This means that "io.file.buffer.size" remains unchanged
* AbstractOzoneContractTest#createOzoneContract implementations ignore the
passed Configuration
** See createContract in AbstractFSContractBase#setup
** See TestRootedOzoneContract, TestOzoneContractFSO, TestOzoneContractLegacy
** Instead, the MiniOzoneCluster#getConf is the one used
This causes issues when the contract test wants to use the configuration (e.g.
by calling getContract().getConf()) and the configuration fields are not set.
> Configuration is not picked up in contract test
> -----------------------------------------------
>
> Key: HDDS-14201
> URL: https://issues.apache.org/jira/browse/HDDS-14201
> Project: Apache Ozone
> Issue Type: Bug
> Components: test
> Reporter: Ivan Andika
> Assignee: Ivan Andika
> Priority: Major
>
> We have contract tests in AbstractOzoneContractTest, which implements
> createConfiguration and createContract.
> There are a few issues with the configurations, not sure if there are any
> reasons
> * createConfiguration does not call the super.createConfiguration
> ** For example, AbstractContractSeekTest#createConfiguration set
> "io.file.buffer.size" configuration, but since
> TestContractSeek#createConfiguration does not call
> AbstractContractSeekTest#createConfiguration and simply calls
> AbstractOzoneContractTest#createOzoneConfig
> ** This means that "io.file.buffer.size" remains unchanged
> * AbstractOzoneContractTest#createOzoneContract implementations ignore the
> passed Configuration
> ** See createContract in AbstractFSContractBase#setup
> ** See TestRootedOzoneContract, TestOzoneContractFSO, TestOzoneContractLegacy
> ** Instead, the MiniOzoneCluster#getConf is the one used, so the
> configuration created in createConfiguration is discarded
> This causes issues when the contract test wants to use the configuration
> (e.g. by calling getContract().getConf()) and the configuration fields are
> not set.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
