adoroszlai opened a new pull request #2262: URL: https://github.com/apache/ozone/pull/2262
## What changes were proposed in this pull request? 1. Restore the requirement for each public type (class, interface, etc.) to have a Javadoc comment. In Checkstyle 8.20 this was moved to a new check, thus missing comments were not flagged after the upgrade from 8.19. 2. Add hopefully meaningful comments for most types where missing. 3. Add placeholders with TODO tag in some cases that need more attention. Will file two separate issues for these. 4. Remove an unnecessary interface definition (`CheckedConsumer` in `MiniOzoneHAClusterImpl`) instead of adding comment. 5. Make `TestInputStreamBase` abstract - it should be executed only as part of its subclasses, not in itself. https://issues.apache.org/jira/browse/HDDS-5204 ## How was this patch tested? ``` hadoop-ozone/dev-support/checks/checkstyle.sh ``` Regular CI: https://github.com/adoroszlai/hadoop-ozone/actions/runs/853608843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
