adoroszlai commented on a change in pull request #2165:
URL: https://github.com/apache/ozone/pull/2165#discussion_r634754365



##########
File path: hadoop-ozone/dist/src/main/smoketest/commonlib.robot
##########
@@ -32,6 +32,6 @@ Kinit HTTP user
 
 Kinit test user
     [arguments]                      ${user}       ${keytab}
-    ${hostname} =       Execute                    hostname
+    ${hostname} =       Execute                    hostname | sed 's/.org//' | 
sed 's/[0-9]//'

Review comment:
       Thanks @elek for addressing my other comments.  I think this one still 
needs to be done.
   
   ```diff
   --- hadoop-ozone/dist/src/main/smoketest/basic/links.robot
   +++ hadoop-ozone/dist/src/main/smoketest/basic/links.robot
   @@ -42,11 +42,11 @@
        Execute             ozone sh bucket link ${source}/readable-bucket 
${target}/readable-link
        Execute             ozone sh bucket link ${source}/readable-bucket 
${target}/unreadable-link
        Execute             ozone sh bucket link ${source}/unreadable-bucket 
${target}/link-to-unreadable-bucket
   -    Execute             ozone sh volume addacl --acl 
user:testuser2/${SCM}@EXAMPLE.COM:r ${target}
   -    Execute             ozone sh volume addacl --acl 
user:testuser2/${SCM}@EXAMPLE.COM:rl ${source}
   -    Execute             ozone sh bucket addacl --acl 
user:testuser2/${SCM}@EXAMPLE.COM:rl ${source}/readable-bucket
   -    Execute             ozone sh bucket addacl --acl 
user:testuser2/${SCM}@EXAMPLE.COM:r ${target}/readable-link
   -    Execute             ozone sh bucket addacl --acl 
user:testuser2/${SCM}@EXAMPLE.COM:r ${target}/link-to-unreadable-bucket
   +    Execute             ozone sh volume addacl --acl 
user:testuser2/[email protected]:r ${target}
   +    Execute             ozone sh volume addacl --acl 
user:testuser2/[email protected]:rl ${source}
   +    Execute             ozone sh bucket addacl --acl 
user:testuser2/[email protected]:rl ${source}/readable-bucket
   +    Execute             ozone sh bucket addacl --acl 
user:testuser2/[email protected]:r ${target}/readable-link
   +    Execute             ozone sh bucket addacl --acl 
user:testuser2/[email protected]:r ${target}/link-to-unreadable-bucket
   
    Can follow link with read access
        Execute             kdestroy
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to