szetszwo commented on code in PR #8774:
URL: https://github.com/apache/ozone/pull/8774#discussion_r2641140779
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBBatchOperation.java:
##########
@@ -125,6 +131,195 @@ public String toString() {
return array != null ? bytes2String(array)
: bytes2String(asReadOnlyByteBuffer());
}
+
+ // This method mimics the ByteWiseComparator in RocksDB.
+ @Override
+ public int compareTo(RDBBatchOperation.Bytes that) {
Review Comment:
@swamirishi , Let's just use ByteWiseComparator. There is no reason to
implemant a new compareTo method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
