adoroszlai commented on code in PR #51:
URL:
https://github.com/apache/ozone-docker-runner/pull/51#discussion_r2645218875
##########
Dockerfile:
##########
@@ -136,32 +67,14 @@ RUN set -eux ; \
rm -f hadoop-${hadoop_version}.tar.gz
# OpenJDK 21
-RUN set -eux ; \
- ARCH="$(arch)"; \
- case "${ARCH}" in \
- x86_64) \
-
url='https://download.java.net/java/GA/jdk21.0.2/f2283984656d49d69e91c558476027ac/13/GPL/openjdk-21.0.2_linux-x64_bin.tar.gz';
\
-
sha256='a2def047a73941e01a73739f92755f86b895811afb1f91243db214cff5bdac3f'; \
- ;; \
- aarch64) \
-
url='https://download.java.net/java/GA/jdk21.0.2/f2283984656d49d69e91c558476027ac/13/GPL/openjdk-21.0.2_linux-aarch64_bin.tar.gz';
\
-
sha256='08db1392a48d4eb5ea5315cf8f18b89dbaf36cda663ba882cf03c704c9257ec2'; \
- ;; \
- *) echo "Unsupported architecture: ${ARCH}"; exit 1 ;; \
- esac && \
- curl -L ${url} -o openjdk.tar.gz && \
- echo "${sha256} *openjdk.tar.gz" | sha256sum -c - && \
- tar xzvf openjdk.tar.gz -C /usr/local && \
- rm -f openjdk.tar.gz
+RUN dnf install -y java-21-openjdk-headless && dnf clean all
Review Comment:
This no longer needs to be a separate step. Please add
`java-21-openjdk-headless` at:
https://github.com/apache/ozone-docker-runner/blob/d9b35b9af3abab9d5d6ba49736edc27414ef41c6/Dockerfile#L21-L22
##########
Dockerfile:
##########
@@ -188,4 +101,4 @@ COPY --chmod=755 entrypoint.sh /usr/local/bin/entrypoint.sh
WORKDIR /opt/hadoop
USER hadoop
-ENTRYPOINT ["/usr/local/bin/dumb-init", "--", "entrypoint.sh"]
+ENTRYPOINT ["/usr/local/bin/dumb-init", "--", "entrypoint.sh"]
Review Comment:
nit: please don't remove newline at EOF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
