adoroszlai commented on PR #9543: URL: https://github.com/apache/ozone/pull/9543#issuecomment-3693814495
> is NOTICE-ratis-thirdparty-misc.txt supposed to be the same as https://github.com/apache/ratis-thirdparty/blob/1.0.10/NOTICE ? I guess it should be like NOTICE in `ratis-thirdparty` binary, which contains the `ratis-thirdparty` source NOTICE, and lists bundled dependencies, too: ``` Apache Ratis Thirdparty Miscellaneous Copyright 2017-2025 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). --- This product bundles protobuf-java which includes the following: Copyright 2008 Google Inc. --- This product bundles gRPC which includes the following text: Copyright 2014 The gRPC Authors --- This product bundles Netty which includes the following text: Copyright 2014 The Netty Project --- This product bundles Gson which includes the following text: Copyright 2008 Google Inc. ``` (This is in `misc/target/classes/META-INF/NOTICE` after a build.) Based on that, it LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
