navinko commented on PR #9529: URL: https://github.com/apache/ozone/pull/9529#issuecomment-3696659380
> > ple worker and they do key comparison like key.compareTo(startKey) , since strings are comprable. > > @navinko > > CodecBufferCodec can be also used in parallel function. As long as one table iterator is used by only one thread we can use CodecBufferCodec there. We can make the value use CodecBufferCodec it would inturn lead to using the RDBStoreCodecBufferIterator otherwise currently the parallel iterator would use RBDStoreByteArrayIterator which is going to be unoptimal. For this we need to get rid of the batching logic which I have seen during my previous benchmark is unnecessary since we would not be blocked on IO ever from rocksdb. Let us get rid of this valueExecutor logic > > https://github.com/apache/ozone/blob/ad891ec2e44d191829feeafc2832f0ae594baf1c/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/util/ParallelTableIteratorOperation.java#L83-L85 Thanks @swamirishi for reviewing and providing the suggested changes . I have added the changes with new test case . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
