szetszwo commented on code in PR #9549:
URL: https://github.com/apache/ozone/pull/9549#discussion_r2651742982
##########
hadoop-hdds/managed-rocksdb/src/test/java/org/apache/hadoop/hdds/utils/db/managed/TestManagedDirectSlice.java:
##########
@@ -39,48 +36,15 @@ public class TestManagedDirectSlice {
@ParameterizedTest
@CsvSource({"0, 1024", "1024, 1024", "512, 1024", "0, 100", "10, 512", "0,
0"})
- public void testManagedDirectSliceWithOffsetMovedAheadByteBuffer(int offset,
int numberOfBytesWritten)
- throws RocksDatabaseException {
+ public void testManagedDirectSliceWithOffset(int offset, int
numberOfBytesWritten) {
Review Comment:
@swamirishi ,
- Just found that the offset, which is not useful anymore, should be removed.
- The hardcoded test cases are too simple: too few and all the sizes are
power of 2. We should test some random sizes.
Filed HDDS-14259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
