ChenSammi commented on code in PR #9515:
URL: https://github.com/apache/ozone/pull/9515#discussion_r2652363938
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -336,6 +373,18 @@ public void setVersion(DiskBalancerVersion version) {
this.version = version;
}
+ @Override
+ public synchronized void start() {
+ // Ensure tmp directories are properly constructed before starting the
service
+ try {
+ constructTmpDir();
+ } catch (IOException e) {
+ LOG.error("Failed to construct diskBalancer tmp directories before
starting service", e);
Review Comment:
Please don't throw RuntimeException. This is one of the feedback given in
the vote thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
