ChenSammi commented on code in PR #9465:
URL: https://github.com/apache/ozone/pull/9465#discussion_r2652457875
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStatusSubcommand.java:
##########
@@ -129,8 +129,11 @@ private String
generateStatus(List<DatanodeDiskBalancerInfoProto> protos) {
contentList.add(estimatedTimeLeft >= 0 ?
String.valueOf(estimatedTimeLeft) : "N/A");
}
- formatBuilder.append("%nNote: Estimated time left is calculated" +
- " based on the estimated bytes to move and the configured disk
bandwidth.");
+ formatBuilder.append("%nNote:%n");
+ formatBuilder.append(" - Estimated time left is calculated based on the
estimated bytes" +
Review Comment:
EstimatedBytesToMove is calculated based on the target disk even state with
the configured threshold.
EstTimeLeft is calculated based on EstimatedBytesToMove and configured disk
bandwidth.
Both EstimatedBytes and EstTimeLeft could be non-zero while no containers
can be moved, especially when the configured threshold or disk capacity is too
small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
