elek commented on a change in pull request #2256: URL: https://github.com/apache/ozone/pull/2256#discussion_r635105872
########## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/stream/StreamingClient.java ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.container.stream; + +import io.netty.bootstrap.Bootstrap; +import io.netty.channel.*; +import io.netty.channel.nio.NioEventLoopGroup; +import io.netty.channel.socket.SocketChannel; +import io.netty.channel.socket.nio.NioSocketChannel; +import io.netty.handler.codec.string.StringEncoder; +import io.netty.util.CharsetUtil; + +import java.util.concurrent.TimeUnit; + +import static org.apache.hadoop.ozone.container.stream.DirstreamServerHandler.END_MARKER; + +public class StreamingClient implements AutoCloseable { + + private final Bootstrap bootstrap; + private final DirstreamClientHandler dirstreamClientHandler; + private EventLoopGroup group; + private int port; + private String host; + + public StreamingClient( + String host, + int port, + StreamingDestination streamingDestination + ) throws InterruptedException { + this.port = port; + this.host = host; + + group = new NioEventLoopGroup(100); + dirstreamClientHandler = new DirstreamClientHandler(streamingDestination); + bootstrap = new Bootstrap(); + bootstrap.group(group) + .channel(NioSocketChannel.class) + .option(ChannelOption.SO_RCVBUF, 1024 * 1024) + .handler(new ChannelInitializer<SocketChannel>() { + @Override + public void initChannel(SocketChannel ch) throws Exception { + ChannelPipeline p = ch.pipeline(); + p.addLast(new StringEncoder(CharsetUtil.UTF_8), + dirstreamClientHandler + ); + } + }); + + } + + + public void stream(String id) { + stream(id, 200L, TimeUnit.SECONDS); + } + + public void stream(String id, long timeout, TimeUnit unit) { + try { + Channel channel = bootstrap.connect(host, port).sync().channel(); + channel.writeAndFlush(id + "\n") + .await(timeout, unit); + channel.closeFuture().await(timeout, unit); + if (!dirstreamClientHandler.getCurrentFileName().equals(END_MARKER)) { + throw new RuntimeException("Streaming is failed. Not all files " + + "are streamed. Please check the log of the server." + + " Last (partial?) streamed file: " + + dirstreamClientHandler.getCurrentFileName()); + } + } catch (InterruptedException e) { + throw new RuntimeException(e); + } + } + + + @Override + public void close() { + group.shutdownGracefully(); Review comment: Good point. I was fully convinced, but when I checked the javadoc to fix it, found this:  I think Netty developers can identify the "sensible" defaults better than me (checkedk and it's 2 sec quite period + 15 sec timeout) so I would leave it as is ;-) Later we can also make it configurable if required... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
