swamirishi commented on code in PR #9576:
URL: https://github.com/apache/ozone/pull/9576#discussion_r2656793929
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/hadoop/hdds/utils/db/TestMinHeapMergeIterator.java:
##########
@@ -38,14 +40,15 @@
import java.util.Map;
import java.util.NoSuchElementException;
import java.util.Set;
+import org.apache.hadoop.hdds.StringUtils;
import org.junit.jupiter.api.Test;
/**
* Unit tests for {@link MinHeapMergeIterator}.
*/
class TestMinHeapMergeIterator {
- private static final Comparator<String> STRING_COMPARATOR =
String::compareTo;
+ private static final Comparator<byte[]> BYTE_COMPARATOR =
UnsignedBytes.lexicographicalComparator();
Review Comment:
The iterator need not be always an Itr<String> it can be
Itr<KeyValue<String, >> and KeyValue doesn't implement equals method
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStore.java:
##########
@@ -198,7 +198,7 @@ default <KEY> ClosableIterator<KeyValue<KEY,
Collection<Object>>> getMergeIterat
KeyValue<KEY, Object> defaultNullValue = newKeyValue(null, null);
Comparator<KeyValue<KEY, Object>> comparator =
Comparator.comparing(KeyValue::getKey, keyComparator);
return new MinHeapMergeIterator<KeyValue<KEY, Object>,
Table.KeyValueIterator<KEY, Object>,
- KeyValue<KEY, Collection<Object>>>(table.length + 1, comparator) {
Review Comment:
It was a typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
