Gargi-jais11 commented on PR #9546: URL: https://github.com/apache/ozone/pull/9546#issuecomment-3713032213
> @Gargi-jais11, is it possible you missed `testGrpcFailoverProxyCalculatesFailoverCountPerRequest`? It tests the two-consequent-request scenario using a single thread and implements the same logic. As a side comment, it tests the behaviour rather than explicitly checking the counter is 0, which is an implementation detail. @greenwich You're absolutely right! I missed that `testGrpcFailoverProxyCalculatesFailoverCountPerRequest()` already covers the sequential request scenario on a single thread. The existing test is sufficient. Thank you for catching this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
