siddhantsangwan commented on code in PR #9570:
URL: https://github.com/apache/ozone/pull/9570#discussion_r2667806502
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
Review Comment:
Do we also need to sync in the else case here, when eob is false? Similar to
the else case that you added in `handlePutBlock`.
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -85,8 +85,9 @@
<name>hdds.container.chunk.write.sync</name>
<value>false</value>
<tag>OZONE, CONTAINER, MANAGEMENT</tag>
- <description>Determines whether the chunk writes in the container happen as
- sync I/0 or buffered I/O operation.
+ <description>For the deprecated FilePerChunkStrategy, this determines
whether the chunk writes
+ in the container happen as sync I/0 or buffered I/O operation. For
FilePerBlockStrategy, this
+ the sync I/O operation only happens before block file is closed.
Review Comment:
Remove "the".
> For FilePerBlockStrategy, this the sync
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
