jojochuang commented on code in PR #9535:
URL: https://github.com/apache/ozone/pull/9535#discussion_r2669823498
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueHandler.java:
##########
@@ -938,4 +952,134 @@ private KeyValueHandler createKeyValueHandler(Path path)
throws IOException {
return kvHandler;
}
+
+ private static class HandlerWithVolumeSet {
+ private final KeyValueHandler handler;
+ private final MutableVolumeSet volumeSet;
+ private final ContainerSet containerSet;
+
+ HandlerWithVolumeSet(KeyValueHandler handler, MutableVolumeSet volumeSet,
ContainerSet containerSet) {
+ this.handler = handler;
+ this.volumeSet = volumeSet;
+ this.containerSet = containerSet;
+ }
+
+ KeyValueHandler getHandler() {
+ return handler;
+ }
+
+ MutableVolumeSet getVolumeSet() {
+ return volumeSet;
+ }
+
+ ContainerSet getContainerSet() {
+ return containerSet;
+ }
+ }
+
+ private HandlerWithVolumeSet createKeyValueHandlerWithVolumeSet(Path path)
throws IOException {
+ ContainerMetrics.remove();
+ final ContainerSet containerSet = newContainerSet();
+ final MutableVolumeSet volumeSet = mock(MutableVolumeSet.class);
+
+ HddsVolume hddsVolume = new HddsVolume.Builder(path.toString()).conf(conf)
+ .clusterID(CLUSTER_ID).datanodeUuid(DATANODE_UUID)
+ .volumeSet(volumeSet)
+ .build();
+ hddsVolume.format(CLUSTER_ID);
+ hddsVolume.createWorkingDir(CLUSTER_ID, null);
+ hddsVolume.createTmpDirs(CLUSTER_ID);
+
when(volumeSet.getVolumesList()).thenReturn(Collections.singletonList(hddsVolume));
+
+ final KeyValueHandler kvHandler =
ContainerTestUtils.getKeyValueHandler(conf,
+ DATANODE_UUID, containerSet, volumeSet);
+ kvHandler.setClusterID(CLUSTER_ID);
+ hddsVolume.getVolumeInfoStats().unregister();
+ hddsVolume.getVolumeIOStats().unregister();
+
+ ContainerController controller = new ContainerController(containerSet,
+ Collections.singletonMap(ContainerType.KeyValueContainer, kvHandler));
+ OnDemandContainerScanner onDemandScanner = new OnDemandContainerScanner(
+ conf.getObject(ContainerScannerConfiguration.class), controller);
+ containerSet.registerOnDemandScanner(onDemandScanner);
+
+ return new HandlerWithVolumeSet(kvHandler, volumeSet, containerSet);
+ }
+
+ @Test
+ public void testReadBlockMetrics() throws Exception {
+ Path testDir = Files.createTempDirectory("testReadBlockMetrics");
+ try {
+ conf.set(OZONE_SCM_CONTAINER_LAYOUT_KEY,
ContainerLayoutVersion.FILE_PER_BLOCK.name());
+ HandlerWithVolumeSet handlerWithVolume =
createKeyValueHandlerWithVolumeSet(testDir);
+ KeyValueHandler kvHandler = handlerWithVolume.getHandler();
+ MutableVolumeSet volumeSet = handlerWithVolume.getVolumeSet();
+ ContainerSet containerSet = handlerWithVolume.getContainerSet();
+
+ long containerID = ContainerTestHelper.getTestContainerID();
+ KeyValueContainerData containerData = new KeyValueContainerData(
+ containerID, ContainerLayoutVersion.FILE_PER_BLOCK,
+ (long) StorageUnit.GB.toBytes(1), UUID.randomUUID().toString(),
+ DATANODE_UUID);
+ KeyValueContainer container = new KeyValueContainer(containerData, conf);
+ container.create(volumeSet, new RoundRobinVolumeChoosingPolicy(),
CLUSTER_ID);
+ containerSet.addContainer(container);
+
+ BlockID blockID = ContainerTestHelper.getTestBlockID(containerID);
+ BlockData blockData = new BlockData(blockID);
+ ChunkInfo chunkInfo = new ChunkInfo("chunk1", 0, 1024);
+ blockData.addChunk(chunkInfo.getProtoBufMessage());
+ kvHandler.getBlockManager().putBlock(container, blockData);
+
+ ChunkBuffer data = ChunkBuffer.wrap(ByteBuffer.allocate(1024));
+ kvHandler.getChunkManager().writeChunk(container, blockID, chunkInfo,
data,
+ DispatcherContext.getHandleWriteChunk());
+
+ ContainerCommandRequestProto readBlockRequest =
+ ContainerCommandRequestProto.newBuilder()
+ .setCmdType(ContainerProtos.Type.ReadBlock)
+ .setContainerID(containerID)
+ .setDatanodeUuid(DATANODE_UUID)
+ .setReadBlock(ContainerProtos.ReadBlockRequestProto.newBuilder()
+ .setBlockID(blockID.getDatanodeBlockIDProtobuf())
+ .setOffset(0)
+ .setLength(1024)
+ .build())
+ .build();
+
+ final AtomicInteger responseCount = new AtomicInteger(0);
+
+ StreamObserver<ContainerCommandResponseProto> streamObserver =
+ new StreamObserver<ContainerCommandResponseProto>() {
+ @Override
+ public void onNext(ContainerCommandResponseProto response) {
+ assertEquals(ContainerProtos.Result.SUCCESS,
response.getResult());
+ responseCount.incrementAndGet();
+ }
+
+ @Override
+ public void onError(Throwable t) {
+ fail("ReadBlock failed", t);
+ }
+
+ @Override
+ public void onCompleted() {
+ }
+ };
+
+ RandomAccessFileChannel blockFile = new RandomAccessFileChannel();
Review Comment:
https://issues.apache.org/jira/browse/HDDS-14370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
