adoroszlai commented on code in PR #8404:
URL: https://github.com/apache/ozone/pull/8404#discussion_r2672729481
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/RequestValidations.java:
##########
@@ -87,10 +98,10 @@ public OMRequest validateRequest(OMRequest request)
public OMResponse validateResponse(OMRequest request, OMResponse response)
throws ServiceException {
- List<Method> validations = registry.validationsFor(
- conditions(request), request.getCmdType(), POST_PROCESS);
- OMResponse validatedResponse = response;
+ List<Method> validations = registry.validationsFor(request.getCmdType(),
POST_PROCESS, this.getVersions(request));
+
+ OMResponse validatedResponse = response.toBuilder().build();
Review Comment:
Yes, please remove, it is unnecessary. `OMResponse` (as a protobuf message)
is immutable, so validators can not change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
