szetszwo commented on code in PR #9552:
URL: https://github.com/apache/ozone/pull/9552#discussion_r2673333053
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBBatchOperation.java:
##########
@@ -135,16 +136,26 @@ public void close() {
}
}
- private abstract static class Op implements Closeable {
+ private abstract static class SingleKeyOp extends Op {
Review Comment:
@swamirishi , have you seen this? You are generating unnecessary long diff
which make the review hard. I am stopping my review here.
```diff
- private abstract static class Op implements Closeable {
...
+ private abstract static class Op implements Closeable {
```
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBStore.java:
##########
@@ -192,20 +191,20 @@ DBUpdatesWrapper getUpdatesSince(long sequenceNumber,
long limitCount)
* @return a closable iterator over merged key-value pairs, where each key
corresponds
* to a collection of values from the tables
*/
- default <KEY> ClosableIterator<KeyValue<KEY, Collection<Object>>>
getMergeIterator(
+ default <KEY> ClosableIterator<KeyValue<KEY, List<Object>>> getMergeIterator(
Review Comment:
Please remove this method, since it
- is unused;
- is untested;
- has nothing to do with DBStore (i.e,. it does not belong to the DBStore
interface).
If this method is needed later on, add it at that time with tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
