adoroszlai commented on a change in pull request #2202:
URL: https://github.com/apache/ozone/pull/2202#discussion_r636278897
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HddsServerUtil.java
##########
@@ -325,6 +327,16 @@ public static int getScmRpcRetryCount(ConfigurationSource
conf) {
OZONE_SCM_HEARTBEAT_RPC_RETRY_COUNT_DEFAULT);
}
+ /**
+ * Get the max limit when get all available reports.
+ * @param conf
+ * @return max limit
+ */
+ public static int getReportMaxLimit(ConfigurationSource conf) {
+ return conf.getInt(HDDS_DATANODE_REPORT_MAX_LIMIT,
+ HDDS_DATANODE_REPORT_MAX_LIMIT_DEFAULT);
+ }
+
Review comment:
Nit: the name `getReportMaxLimit` seems too generic when placed in the
utility class. Can you please either move it to some datanode-specific class
(e.g. `StateContext` itself), or rename it to be more specific?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
