[ 
https://issues.apache.org/jira/browse/HDDS-12523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18051105#comment-18051105
 ] 

Navin Kumar commented on HDDS-12523:
------------------------------------

Hi [~adoroszlai] 
Regarding this jira , Can we add a new top level command "ozone config" like 
[https://github.com/apache/ozone/blob/f2b367fba3a3f1e857282da5a5f7a33303ab5363/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/conf/OzoneGetConf.java#L34]

and their subcommands like - get, create,om and scm , also by reusing existing 
handler ?
{code:java}
- ozone config
                -get 
                -create
                -om
                -scm
{code}
{code:java}
@Command(
    name = "ozone config",
    description = "Ozone config commands",
    subcommands = {
      //get
      //create
      //om
      //scm
    },
    mixinStandardHelpOptions = true,
    versionProvider = HddsVersionProvider.class
)
public class OzoneConfig extends GenericCli {
}
{code}

> Move getconf and genconf to ozone config
> ----------------------------------------
>
>                 Key: HDDS-12523
>                 URL: https://issues.apache.org/jira/browse/HDDS-12523
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: Ozone CLI
>            Reporter: Attila Doroszlai
>            Assignee: Attila Doroszlai
>            Priority: Major
>
> {{ozone getconf}} and {{ozone genconf}} are very similar in name, and clutter 
> the top-level CLI namespace.  We should move them as subcommands under new 
> {{ozone config}} command, {{get}} and {{create}}, respectively.
> This is a good opportunity to improve {{getconf}}, which has quite some 
> backwards-compatibility baggage, supporting both normal and option-like 
> subcommands:
> {code}
> Commands:
>   confKey, -confKey                         gets a specific key from the
>                                               configuration
>   storagecontainermanagers, -storagecontainermanagers
>                                             gets list of ozone storage
>                                               container manager nodes in the
>                                               cluster
>   ozonemanagers, -ozonemanagers             gets list of Ozone Manager nodes 
> in
>                                               the cluster
> {code}
> Existing {{ozone getconf}} could be kept for compatibility as is, but hidden.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to