szetszwo commented on code in PR #9623:
URL: https://github.com/apache/ozone/pull/9623#discussion_r2679984505
##########
hadoop-hdds/common/pom.xml:
##########
@@ -192,6 +192,14 @@
<artifactId>slf4j-reload4j</artifactId>
<scope>runtime</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>hdds-config</artifactId>
+ <version>${hdds.version}</version>
+ <classifier>tests</classifier>
Review Comment:
Add it to `dependencyManagement` and then remove `version` and `classifier`
for all the usages.
```diff
+++ b/pom.xml
@@ -1023,6 +1023,12 @@
<artifactId>hdds-config</artifactId>
<version>${hdds.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.ozone</groupId>
+ <artifactId>hdds-config</artifactId>
+ <version>${hdds.version}</version>
+ <type>test-jar</type>
+ </dependency>
<dependency>
<groupId>org.apache.ozone</groupId>
<artifactId>hdds-container-service</artifactId>
```
##########
hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/TestBlockOutputStreamIncrementalPutBlock.java:
##########
@@ -53,7 +53,7 @@ public class TestBlockOutputStreamIncrementalPutBlock {
private final String volumeName = UUID.randomUUID().toString();
private final String bucketName = UUID.randomUUID().toString();
private OzoneBucket bucket;
- private final ConfigurationSource config = new InMemoryConfiguration();
+ private final ConfigurationSource config = new
InMemoryConfigurationForTesting();
Review Comment:
Let's declare it with InMemoryConfigurationForTesting and remove the casting.
```java
private final InMemoryConfigurationForTesting config = new
InMemoryConfigurationForTesting();
```
```java
//init
config.setFromObject(clientConfig);
config.setBoolean(OzoneConfigKeys.OZONE_HBASE_ENHANCEMENTS_ALLOWED,
true);
config.setBoolean("ozone.client.hbase.enhancements.allowed", true);
config.setBoolean(OzoneConfigKeys.OZONE_FS_HSYNC_ENABLED, true);
config.setInt("ozone.client.bytes.per.checksum", 8192);
```
##########
hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/checksum/TestFileChecksumHelper.java:
##########
@@ -90,11 +90,11 @@ public class TestFileChecksumHelper {
@BeforeEach
public void init() throws IOException {
- ConfigurationSource config = new InMemoryConfiguration();
+ ConfigurationSource config = new InMemoryConfigurationForTesting();
Review Comment:
Similarly, declare it with InMemoryConfigurationForTesting and remove the
casting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
