errose28 commented on code in PR #9376:
URL: https://github.com/apache/ozone/pull/9376#discussion_r2684075195
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java:
##########
@@ -123,6 +139,7 @@ private void emitSafeModeStatus() {
// notify SCMServiceManager
Review Comment:
Can we just put one call to `logSafeModeStatus` on the line above this in
addition to the one being logged every minute, instead of placing it in various
spots around the safemode manager? This looks like a simpler way to handle the
intermittent updates (pre-check complete, safemode exit) that may occur before
the minute elapses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
