ChenSammi commented on code in PR #9593:
URL: https://github.com/apache/ozone/pull/9593#discussion_r2684681163
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCRule.java:
##########
@@ -142,14 +143,6 @@ public boolean isTagEnable() {
/**
* Validates the lifecycle rule.
- * - ID length should not exceed the allowed limit
Review Comment:
I believe that AWS will not change it's API spec and behavior frequently, so
the validation logic is likely being stable. Besides, any future patch of this
feature, likely at least one of us will help with the review, so we can
guarantee that comments can get updated together with code change.
Let's keep these comments. It's very useful when I want to check that
what's valid, and what's invalid of a configuration, than going through the
code, as there are a few edge cases I would totally not sure about the
conclusion without referring to these comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
