ChenSammi commented on code in PR #9602:
URL: https://github.com/apache/ozone/pull/9602#discussion_r2684702382
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/S3SecurityUtil.java:
##########
@@ -166,4 +175,26 @@ private static boolean isRevokedStsToken(String
sessionToken, OzoneManager ozone
throw new OMException(msg, e, INTERNAL_ERROR);
}
}
+
+ /**
+ * Returns true if the originalAccessKeyId of the STS token has been revoked.
+ */
+ private static boolean isOriginalAccessKeyIdRevoked(STSTokenIdentifier
stsTokenIdentifier, OzoneManager ozoneManager)
+ throws OMException {
+ final String originalAccessKeyId =
stsTokenIdentifier.getOriginalAccessKeyId();
+ if (originalAccessKeyId == null) {
Review Comment:
originalAccessKeyId is already checked in
ensureEssentialFieldsArePresentInToken(). Rest looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
