errose28 commented on a change in pull request #2265:
URL: https://github.com/apache/ozone/pull/2265#discussion_r637194181
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOmVersionManagerRequestFactory.java
##########
@@ -33,12 +33,14 @@
import
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.OMRequest;
import org.junit.Assert;
import org.junit.BeforeClass;
+import org.junit.Ignore;
import org.junit.Test;
import org.reflections.Reflections;
/**
* Test OmVersionFactory.
*/
+@Ignore
Review comment:
If we are saving the version request factory for potentially later use,
we might want to add a comment to it explaining otherwise it looks like dead
code.
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerPrepare.java
##########
@@ -77,6 +78,7 @@ public void setup() throws Exception {
* Calls prepare on all OMs when they have no transaction information.
* Checks that they are brought into prepare mode successfully.
*/
+ @Ignore("Absorbed into testPrepareWithTransactions test to save on CI time!")
Review comment:
Looks like prepare with transactions fully covers this now. Can we just
delete this test?
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOMVersionManager.java
##########
@@ -101,6 +103,7 @@ public void
testOMLayoutFeaturesHaveIncreasingLayoutVersion()
verify(omMock, times(UpgradeActionType.values().length)).getVersion();
}
+ @Ignore
Review comment:
What is the reason for ignoring this test now? Maybe we should add a
comment explaining why it is ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
