ivandika3 commented on code in PR #9626:
URL: https://github.com/apache/ozone/pull/9626#discussion_r2688648070
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineMetrics.java:
##########
@@ -189,4 +190,12 @@ void incNumPipelineContainSameDatanodes() {
public void updatePipelineCreationLatencyNs(long startNanos) {
pipelineCreationLatencyNs.add(Time.monotonicNowNanos() - startNanos);
}
+
+ /**
+ * Return number of blocks allocated across all pipelines.
+ */
+ @VisibleForTesting
Review Comment:
Thanks for the info. I added it as a force of habit, but I agree that the
enforcement of the annotation is lacking, causing the annotation to not be
useful.
I removed this annotation.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java:
##########
@@ -144,9 +145,17 @@ public OMRequest preExecute(OzoneManager ozoneManager)
throws IOException {
// As for a client for the first time this can be executed on any OM,
// till leader is identified.
UserInfo userInfo = getUserInfo();
Review Comment:
Good catch, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
