echonesis commented on code in PR #9627:
URL: https://github.com/apache/ozone/pull/9627#discussion_r2688887944


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServer.java:
##########
@@ -427,4 +445,32 @@ public ReconTaskController getReconTaskController() {
   ReconHttpServer getHttpServer() {
     return httpServer;
   }
+
+  /**
+   * Get the collection of Recon admin usernames.
+   *
+   * @return Collection of admin usernames
+   */
+  public Collection<String> getReconAdminUsernames() {
+    return reconAdmins.getAdminUsernames();
+  }
+
+  /**
+   * Get the collection of Recon admin groups.
+   *
+   * @return Collection of admin groups
+   */
+  public Collection<String> getReconAdminGroups() {

Review Comment:
   Thanks @devmadhuu !
   These methods follow the same pattern as OM's `getOmAdminUsernames()` and 
`getOmAdminGroups()` for consistency. They're not currently used in Recon.
   I will remove them in a follow-up commit if preferred.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to