chungen0126 commented on PR #9614: URL: https://github.com/apache/ozone/pull/9614#issuecomment-3754627537
> @YutaLin Thanks for your patch. > > I may be missing something, but do we need to upgrade the framework for the lifecycle feature? > > My understanding is the lifecycle feature only adds a few DB definition and interfaces without altering the existing DB field. If we roll back after upgrading, it might leave some useless data in the DB, but it shouldn't cause data to become unreadable. Thanks @xichen01 for the review. You are right that we don't change existing fields, but I'm concerned about skipping the upgrade process for a couple of reasons: 1. Based on my understanding of the design doc. See https://github.com/apache/ozone/blob/master/hadoop-hdds/docs/content/design/upgrade-dev-primer.md?plain=1#L76-L81, adding a new Column Family (CF) must happen during the ON_FINALIZE stage. 2. In my opinion, It is risky If we write lifecycle data and then rollback, some "ghost data" will stay in RocksDB. When we upgrade again later, this data might start the lifecycle check and delete things without notice. I think it's safer to follow the upgrade framework here. Let me know your thoughts! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
