GlenGeng commented on pull request #2277: URL: https://github.com/apache/ozone/pull/2277#issuecomment-846851315
Thanks @adoroszlai for the clarificaiton! From the fix, it shows that `CloseContainerCommand` is the only `SCMCommand` translated into a `ContainerCommandRequestProto`, which go through ratis. I guess it is why the token is needed for `CloseContainerCommand `. Will it be better to move the token to `DeleteContainerCommandProto` to narrow down its visibility ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
