ashishkumar50 commented on PR #9630: URL: https://github.com/apache/ozone/pull/9630#issuecomment-3766534960
> It seems the three test methods (testDeletedContainerWithStaleClosedReplicaRatis, testDeletedContainerWithLowerBcsidStaleReplicaRatis, and testDeletedECContainerWithStaleClosedReplicaShouldNotForceDelete) share duplicated code for creating ContainerReportHandler, building ContainerReportsProto, sending messages via reportHandler.onMessage(), and verifying DeleteContainerCommand. Could we try to extract a helper method like sendReportAndVerifyDeleteCommand() or something that handles the common setup and verification logic? Extracted common code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
