jojochuang commented on code in PR #9585:
URL: https://github.com/apache/ozone/pull/9585#discussion_r2709553040
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java:
##########
@@ -353,25 +356,24 @@ private Collection<Path>
getSnapshotLocalDataPaths(OmSnapshotLocalDataManager lo
* handling deduplication and managing resource locking.
*
* @param sstFilesToExclude Set of SST file identifiers to exclude from
the archive.
- * @param tmpdir Temporary directory for intermediate
processing.
* @param snapshotPaths Set of paths to snapshot directories to be
processed.
* @param maxTotalSstSize AtomicLong to track the cumulative size of SST
files included.
- * @param archiveOutputStream Archive output stream to write the snapshot
data.
- * @param hardLinkFileMap Map of hardlink file paths to their unique
identifiers for deduplication.
* @throws IOException if an I/O error occurs during processing.
*/
- void transferSnapshotData(Set<String> sstFilesToExclude, Path tmpdir,
Collection<Path> snapshotPaths,
+ void collectSnapshotData(Set<String> sstFilesToExclude, Collection<Path>
snapshotPaths,
Review Comment:
```suggestion
@VisibleForTesting
void collectSnapshotData(Set<String> sstFilesToExclude, Collection<Path>
snapshotPaths,
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java:
##########
Review Comment:
```suggestion
* Collects the snapshots to be transferred from the specified snapshot
directories into the archive output stream,
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java:
##########
@@ -353,25 +356,24 @@ private Collection<Path>
getSnapshotLocalDataPaths(OmSnapshotLocalDataManager lo
* handling deduplication and managing resource locking.
*
* @param sstFilesToExclude Set of SST file identifiers to exclude from
the archive.
- * @param tmpdir Temporary directory for intermediate
processing.
* @param snapshotPaths Set of paths to snapshot directories to be
processed.
* @param maxTotalSstSize AtomicLong to track the cumulative size of SST
files included.
- * @param archiveOutputStream Archive output stream to write the snapshot
data.
- * @param hardLinkFileMap Map of hardlink file paths to their unique
identifiers for deduplication.
* @throws IOException if an I/O error occurs during processing.
Review Comment:
```suggestion
* @param omdbArchiver helper to archive the OM DB.
* @throws IOException if an I/O error occurs during processing.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
