[
https://issues.apache.org/jira/browse/HDDS-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Kumar resolved HDDS-14429.
---------------------------------
Fix Version/s: 2.2.0
Resolution: Implemented
> Avoid Duplicate Transaction Deletion and Replica-Level Tx Size Updates
> ----------------------------------------------------------------------
>
> Key: HDDS-14429
> URL: https://issues.apache.org/jira/browse/HDDS-14429
> Project: Apache Ozone
> Issue Type: Improvement
> Components: SCM
> Reporter: Priyesh K
> Assignee: Priyesh K
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.2.0
>
>
> Currently, the transaction deletion logic is executed twice : once at
> [here|https://github.com/ashishkumar50/ozone/blob/b9ba495d23ee9ab856093afb9f61cfe5c7feeb21/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java#L443]
> and again inside
> [removeTransactions|https://github.com/ashishkumar50/ozone/blob/b9ba495d23ee9ab856093afb9f61cfe5c7feeb21/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java#L446].
> This results in redundant delete calls to the database.
> Additionally,
> [addTxToTxSizeMap|https://github.com/ashishkumar50/ozone/blob/b9ba495d23ee9ab856093afb9f61cfe5c7feeb21/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java#L284]
> is being invoked for each replica, even though the transaction size is
> tracked at the {*}transaction level{*}, not per replica. Calling this method
> per replica is unnecessary and can lead to incorrect aggregation and extra
> processing.
> We can move this code
> [here|https://github.com/ashishkumar50/ozone/blob/b9ba495d23ee9ab856093afb9f61cfe5c7feeb21/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java#L289]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
