hevinhsu commented on PR #9612: URL: https://github.com/apache/ozone/pull/9612#issuecomment-3776723119
Thanks @ivandika3 for the reviews. I’ve fixed the merge-related issue you pointed out and addressed the nits, including renaming `eTag` to `md5Hash`. I agree with the rename. As you pointed out, ETag is not guaranteed to be an MD5 hash (especially for multipart uploads), so using `md5Hash` avoids conflating ETag semantics with an MD5 digest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
