aswinshakil opened a new pull request, #9656: URL: https://github.com/apache/ozone/pull/9656
## What changes were proposed in this pull request? `SnapshotDeletingService` incorrectly checks the Ratis Buffer Limit when we invoke `submitSnapshotMoveDeletedKeys` , it adds all the keys to the builder and then checks the size of the message. Later, it again adds more `deletedKeys`, `deletedDirs` and `renamedKeys` on it, The message size is already over the ratis buffer limit, instead of creating a new builder we re-use the same builder. Ideally we should stop iterating through the snapshot-related tables when we hit the buffer limit even before going to `submitSnapshotMoveDeletedKeys` ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-14432 ## How was this patch tested? Existing Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
