greenwich commented on PR #9641: URL: https://github.com/apache/ozone/pull/9641#issuecomment-3788450439
Hi, thanks for CC-ing me. Great MR! Thank you! Unfortunately, I am late for the review. A few more thoughts going forward: 1. Add `OMFollowerReadMetrics` to track the follower read-specific metrics to monitor its effectiveness, health issues, and measure performance. 2. As you mentioned in the comments, using the simple round-robin routing without checking node roles might not be ideal. Since OM already exposes OmRoleInfo via ServiceInfo, we can leverage it. - We can either cache role information (periodically refresh OM roles in the background), - or check the role per request Both approaches have their own pros and cons. 3. Read after write consistency. Let's imagine the following scenario: - Client writes/updates "abc" to OM leader (index 10) - Same client reads key "abc" from follower (index 9) - Client gets "key not found" error or inconsistent data. Does the client need to track the applied index? (This may require unit/integration test first). 4. Good to see the performance benchmarks about read throughput, latency, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
