sarvekshayr commented on code in PR #278:
URL: https://github.com/apache/ozone-site/pull/278#discussion_r2720941715


##########
docs/03-core-concepts/02-replication/01-storage-containers.md:
##########
@@ -1,5 +1,38 @@
+<!---
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
 # Storage Containers
 
-**TODO:** File a subtask under 
[HDDS-9857](https://issues.apache.org/jira/browse/HDDS-9857) and complete this 
page or section.
+Storage Containers, or Containers (not to be confused with Docker containers) 
are the fundamental replication unit of Ozone, they are managed by the Storage 
Container Manager (SCM) service.
+
+Containers are big binary units (5Gb by default) which can contain multiple 
blocks:
+
+![Containers](Containers.png)
+
+Blocks are local information and not managed by SCM. Therefore even if 
billions of small files are created in the system (which means billions of 
blocks are created), only of the status of the containers will be reported by 
the Datanodes and containers will be replicated.
+When Ozone Manager requests a new Block allocation from the SCM, SCM will 
identify the suitable container and generate a block id which contains 
`ContainerId` + `LocalId`. Client will connect to the Datanode which stores the 
Container, and Datanode can manage the separated block based on the `LocalId`.
+
+## Open vs. Closed containers
+
+When a container is created it starts in an OPEN state. When it's full (~5GB 
data is written), container will be closed and becomes a CLOSED container.
+
+The fundamental differences between OPEN and CLOSED containers:
 
-Provide a high level summary of storage containers and their purpose. 
Technically this is just for context and deep understanding is not required by 
most users of the system. The System Internals section of the docs will have 
much more details on containers.
+| OPEN | CLOSED |
+|-----------------------------------|-----------------------------------------|
+| mutable | immutable |
+| replicated with RAFT (Ratis) | Replicated with async container copy |

Review Comment:
   Use capitalisation here. 
   ```suggestion
   | Mutable | Immutable |
   | Replicated with RAFT (Ratis) | Replicated with async container copy |
   ```



##########
docs/03-core-concepts/02-replication/01-storage-containers.md:
##########
@@ -1,5 +1,38 @@
+<!---

Review Comment:
   Let's remove the license and add `sidebar_label`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to