fmorg-git commented on PR #9654: URL: https://github.com/apache/ozone/pull/9654#issuecomment-3802908133
> I think we can remove all the appearance of `OS3Exception` in `S3STSEndpoint` class. While developing in [the previous PR](https://github.com/apache/ozone/pull/9343), I added them to handle errors in endpoint. Later I replaced the way to handle errors with XML format instead of `OS3Exception` and I forgot to remove them. Can you remove them please? Per internal communication, I noticed recently the endpoint was returning plain text for errors when it should have been returning XML. The `OS3Exception` has an error XML format, but testing against AWS STS shows the error response XML structure for STS errors is slightly different than for S3 errors, so I revamped the error handling in this commit https://github.com/apache/ozone/pull/9654/commits/bdb33a43f5f0fe0bb6a2ae1f8d7790cf439c79e8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
