adoroszlai commented on PR #9631: URL: https://github.com/apache/ozone/pull/9631#issuecomment-3804863711
> 1. Since the maps are now immutable, we need to be sure there isn't existing code that's getting and trying to change their contents. There will be runtime exceptions if there is. Hopefully existing tests cover this. > 2. Currently, `BlockOutputStreamEntryPool` (and its `keyArgs`) is constructed during the construction of `KeyOutputStream` and then the `keyArgs` object is used during `allocateNewBlock` etc. With this change, every time `allocateNewBlock` is called, a new `OmKeyArgs` object will be constructed. Can that increase GC churn significantly? I suppose this only matters for really big keys with multiple blocks. For multi-block keys `allocateNewBlock` happens for each 256MB (default). A new instance of `OmKeyArgs` is nothing compared to that, as it mostly just holds references to the same data structures as the builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
