gardenia commented on code in PR #9363:
URL: https://github.com/apache/ozone/pull/9363#discussion_r2742463737
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -917,6 +917,68 @@ message SnapshotDiffJobProto {
optional double keysProcessedPct = 13;
}
+/**
+ * Per request type entities to hold arguments
+ * captured for CompletedRequestInfo
+ */
+message CreateVolumeOperationArgs {
+}
+
+message DeleteVolumeOperationArgs {
+}
+
+message CreateBucketOperationArgs {
+}
+
+message DeleteBucketOperationArgs {
+}
+
+message CreateKeyOperationArgs {
+}
+
+message RenameKeyOperationArgs {
+ required string toKeyName = 1;
+}
+
+message DeleteKeyOperationArgs {
+}
+
+message CommitKeyOperationArgs {
+}
+
+message CreateDirectoryOperationArgs {
+}
+
+message CreateFileOperationArgs {
+ required bool isRecursive = 2;
+ required bool isOverwrite = 3;
+}
+
+
+/**
+ * CompletedRequestInfo table entry
+ */
+message CompletedRequestInfo {
+
+ optional int64 trxLogIndex = 1;
Review Comment:
I have left it as optional for now but I can see both sides. @ChenSammi is
correct that it doesn't make sense to insert a row without it and it might be
somewhat self documenting in the protos to see which fields are required.
However, there are indeed checks at the code level to enforce that it is
provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
