Gargi-jais11 commented on code in PR #9719:
URL: https://github.com/apache/ozone/pull/9719#discussion_r2772368572
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerInfo.java:
##########
@@ -275,7 +296,8 @@ public HddsProtos.ContainerInfoProto getProtobuf() {
.setDeleteTransactionId(getDeleteTransactionId())
.setOwner(getOwner())
.setSequenceId(getSequenceId())
- .setReplicationType(getReplicationType());
+ .setReplicationType(getReplicationType())
+ .setAckMissing(getAckMissing());
Review Comment:
@sarvekshayr
This is not related to you changes but I see that in this `getProtobuf`
there are duplicates settings done, Is it intentional? or else we should remove
this duplicate.
1. `.setContainerID(getContainerID())`-: Line 291 and Line 295 is called
twice.
2. `.setReplicationType(getReplicationType())` -: Line 299 and Line 310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
