Russole commented on PR #9733: URL: https://github.com/apache/ozone/pull/9733#issuecomment-3868665661
Thanks @szetszwo! The current change compiles and all CI checks pass: https://github.com/Russole/ozone/actions/runs/21776638347 Agreed that SCMRatisRequestProto and SCMRatisResponseProto still extend `com.google.protobuf.*`, as they are generated by the standard protobuf compiler. This PR focuses on the SCM↔Ratis message boundary, updating the wrapping/parsing to use Ratis shaded protobuf types and avoid extra `byte[]` conversions. Let me know if you think it makes sense to open a follow-up JIRA for generating the SCM Ratis protos with the shaded protobuf. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
