[
https://issues.apache.org/jira/browse/HDDS-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057347#comment-18057347
]
weiming commented on HDDS-14591:
--------------------------------
[~ayarovoy] I’d like to work on this. Could you assign the issue to me?
> BlockManagerImpl should not check finalization status on every putBlock
> -----------------------------------------------------------------------
>
> Key: HDDS-14591
> URL: https://issues.apache.org/jira/browse/HDDS-14591
> Project: Apache Ozone
> Issue Type: Bug
> Reporter: Andrey Yarovoy
> Priority: Major
>
> with [https://github.com/apache/ozone/pull/7012/changes] every putBlock is
> going through the following block:
> {code:java}
> boolean incrementalEnabled = true;
> if
> (!VersionedDatanodeFeatures.isFinalized(HDDSLayoutFeature.HBASE_SUPPORT)) {
> if (isPartialChunkList(data)) {
> throw new StorageContainerException("DataNode has not finalized "
> +
> "upgrading to a version that supports incremental chunk
> list.", UNSUPPORTED_REQUEST);
> }
> incrementalEnabled = false;
> } {code}
> this logic is needed ONLY if
> !VersionedDatanodeFeatures.isFinalized(HDDSLayoutFeature.HBASE_SUPPORT was
> not true on start up and finalization is in progress. If DN detects that
> feature is finalized on startup or the first time detected after finalization
> it should cache the finalization status and use it instead of doing the full
> check on each putBlock request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
