errose28 commented on code in PR #9723:
URL: https://github.com/apache/ozone/pull/9723#discussion_r2783384885
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -1372,11 +1388,10 @@ private FinalizeUpgradeProgressResponse
reportUpgradeProgress(
}
private PrepareStatusResponse getPrepareStatus() {
- OzoneManagerPrepareState.State prepareState =
- impl.getPrepareState().getState();
+ // Prepare is no longer used, always return NOT_PREPARED
return PrepareStatusResponse.newBuilder()
- .setStatus(prepareState.getStatus())
- .setCurrentTxnIndex(prepareState.getIndex()).build();
+ .setStatus(PrepareStatusResponse.PrepareStatus.NOT_PREPARED)
Review Comment:
Good catch, I was thinking from the server side this would be the accurate
thing to return, but it breaks older clients who will wait indefinitely for the
`PREPARE_COMPLETED` response. This would have failed the acceptance tests too.
I will update this so the server always returns `PREPARE_COMPLETED` making it
a no-op from the client side as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
